Google Git
Sign in
chromium / chromium / src / 66aa2aa2718d31ff8ea28161b73273ed3673d0ed
commit66aa2aa2718d31ff8ea28161b73273ed3673d0ed[log] [tgz]
authorFrédéric Wang <fwang@igalia.com>Thu Oct 05 15:50:37 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Oct 05 15:50:37 2023
tree2a0cfbd538399aea62707699461d8db069ebd926
parent66275049d0bd6ced96c72ad2f82eb8c18dbe0628 [diff]
[mathml] Tweak MathItalicCorrection and add unit test for a edge case.

Code coverage reports the case !harfbuzz_face as uncovered [1]. In
practice, MathItalicCorrection is indeed only used in
StretchyOperatorShaper::Shape where this condition is checked before.
This CL strengthen a bit this by actually checking whether the font
has a MATH table, aligning the behavior with the documentation in the
header file [2] and with the MathConstant method. A unit test is also
added to cover that case.

[1] https://analysis.chromium.org/coverage/p/chromium/file?path=//third_party/blink/renderer/platform/fonts/opentype/open_type_math_support.cc&revision=c8a01d35ed430e49e8275f641f735e689a97c105#131
[2] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/fonts/opentype/open_type_math_support.h;l=91;drc=047c7dc4ee1ce908d7fea38ca063fa2f80f92c77

Bug: 1464154
Change-Id: I7f070376d7d111fcfd33b5c875d5268f7676556f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4689687
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Frédéric Wang <fwang@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1205856}
2 files changed
tree: 2a0cfbd538399aea62707699461d8db069ebd926
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. DEPS
  75. DIR_METADATA
  76. LICENSE
  77. LICENSE.chromium_os
  78. OWNERS
  79. PRESUBMIT.py
  80. PRESUBMIT_test.py
  81. PRESUBMIT_test_mocks.py
  82. README.md
  83. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.