Google Git
Sign in
chromium / chromium / src / 66fafcb09a32c34b8a9a0866f2c6ecbcd036bf78
commit66fafcb09a32c34b8a9a0866f2c6ecbcd036bf78[log] [tgz]
authorRouslan Solomakhin <rouslan@chromium.org>Thu Nov 17 14:10:50 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Nov 17 14:10:50 2022
tree0ef23506a3c6966a2dd184182fa3f0057e6b1f45
parenta3b105722c6ee802944625a21900ab445639e179 [diff]
[Web Payment] Reduce number of test delegates.

This patch merges a couple of test implementations of
ChromePaymentRequestDelegate into a single
TestChromePaymentRequestDelegate and removes its constructor
parameters, so it can be used more easily in the next patches.

This is step 1 in multi-step patch to make
ServiceWorkerPaymentAppFactory (instead of RenderFrameHost) own
ServiceWorkerPaymentAppFinder, in order to simplify object ownership in
Web Payment code. Steps:
1) Reduce # of test implementations of ChromePaymentRequestDelegate.
2) Move PaymentRequest constructor parameters into the delegate.
3) Tests affect ServiceWorkerPaymentAppFinder through the delegate.
4) ServiceWorkerPaymentAppFactory owns ServiceWorkerPaymentAppFinder.

Bug: 1382826
Change-Id: I9801deda8cb1d6e5cbee58b8165b398c270af5d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4023844
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1072770}
14 files changed
tree: 0ef23506a3c6966a2dd184182fa3f0057e6b1f45
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.