Google Git
Sign in
chromium / chromium / src / 2cc0167b770497a91056a141e5c0e295a49836ef
commit2cc0167b770497a91056a141e5c0e295a49836ef[log] [tgz]
authorOleg Davydov <burunduk@chromium.org>Tue Feb 05 14:32:48 2019
committerCommit Bot <commit-bot@chromium.org>Tue Feb 05 14:32:48 2019
tree95ab034c65f5463d40502ff90dc5e76b0352b2d9
parent6864b393c8b5e36a6eb91eb0f277d0ea8f5b50d7 [diff]
Add blacklist checks for javascript:// ulrs

Investigation in
https://bugs.chromium.org/p/chromium/issues/detail?id=913334 showed that
blacklists (URLBlacklist and URLWhitelist policies) are applied only to
“normal” urls, not ones with “javascript” scheme. This is because this
URLs (and some more, like “chrome://crash”) are so-called Renderer Debug
URLs, they don't need network fetch or something like that, and they are
just passed into renderer.

So to make blacklists work for such URLs we have to make additional
check.

Bug: 913334
Change-Id: I109cf27640d641fc35f449ef0bfd622d19a6c27b
Reviewed-on: https://chromium-review.googlesource.com/c/1436372
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Oleg Davydov <burunduk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629135}
7 files changed
tree: 95ab034c65f5463d40502ff90dc5e76b0352b2d9
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .