commit | 67fec5fb4cb19ef394c0be06391cc4d2b962db73 | [log] [tgz] |
---|---|---|
author | Cici Ruan <cuicuiruan@google.com> | Thu Sep 21 01:22:05 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Sep 21 01:22:05 2023 |
tree | 3590f7618c967a3a9fe7f7065f2140478d7855b7 | |
parent | 2e33f5483862c4b272ae49f91209ccee4bffdf3f [diff] |
arc/gio: UI should show above shelf if shelf is visible This CL makes the ButtonOptionsMenu and ButtonLabelList show above the shelf if the shelf is visible. So instead of calculating the position based on root window bounds, calculate the position based on the available bounds excluding shelf if the shelf is visible. Bug: b/301177039 Test: manual test Test: unit_tests --gtest-filter=*ButtonOptionsMenu* Change-Id: Id9d8b5f2e171e4857242d9ff06426b324b6033be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4878134 Reviewed-by: David Jacobo <djacobo@chromium.org> Reviewed-by: Joseph Pang <pjlee@google.com> Commit-Queue: Cici Ruan <cuicuiruan@google.com> Cr-Commit-Position: refs/heads/main@{#1199360}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.