Google Git
Sign in
chromium / chromium / src / 683665e0c20092f0646a5b2e35740935f0247541
commit683665e0c20092f0646a5b2e35740935f0247541[log] [tgz]
authorDan Harrington <harringtond@chromium.org>Wed May 12 21:08:33 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed May 12 21:08:33 2021
tree1c2dd05bd634746de4fad6f24d0b6c5cd613f78e
parentcba54c55437298e484bbdf1f023a9c3a6f6fdf1f [diff]
feed: ntp MV tiles should not see feed navigations

Clicking on NTP feed cards should not influence the MV
tiles on the NTP. The prior implementation relied on setting
a unique referrer. This was brittle, and finally broke when
the referrer of the feed was changed.

This CL instead remembers the last several Feed articles
tapped, and then checks this list to determine if the navigation
is from the Feed. This isn't perfect. If the user taps
on a Feed card, and then later navigates to that same page from
another method, we will ignore the navigation for MV tiles purposes
when we shouldn't

Bug: 1194788
Change-Id: I024e1829f5236f3b3566b0261e88e0475801b673
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2878557
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#882285}
20 files changed
tree: 1c2dd05bd634746de4fad6f24d0b6c5cd613f78e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.