commit | 684e7a64e1badab0cafbab32ff97d613473caf0a | [log] [tgz] |
---|---|---|
author | Luciano Pacheco <lucmult@chromium.org> | Wed Jan 24 01:31:01 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jan 24 01:31:01 2024 |
tree | 8af8ed1dbec0827ed0deadd55de5683801a24852 | |
parent | a895002554d8a4d80b202c7f78576aebcc6fabf0 [diff] |
Files app: Change function registration in the integration tests Before this CL the test functions were registered directly to the namespace `testcase`. However this had 2 drawbacks: 1. It required to import all files in background.js, which could cause circular imports, because some helper functions live inside background.js and are imported by the test files. 2. When converting to TS, the type system doesn't allow to easily append functions to the `testcase` namespace, it requires to use the syntax: `testcase['testName'] = async () => {}`. This CL changes the registration to happen directly inside the testcase.ts, so the test files just need to export their test functions. Convert android_photos.js to TS as example for further conversions. Bug: b:319189127 Change-Id: I829d5d464571eae035c7ab2cf63d07a7dbb02b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5221804 Reviewed-by: Wenbo Jie <wenbojie@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/main@{#1251169}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.