commit | 91011c8d15cb9520bcf87ad320706c6bd46198be | [log] [tgz] |
---|---|---|
author | Mark Pearson <mpearson@chromium.org> | Mon Jan 27 23:09:53 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Jan 27 23:09:53 2025 |
tree | 09493d7a4a701fdc0795bf5bc904e323bdde0df8 | |
parent | a271f7c0679509c1a2ce671d4ff8ebdc5cda8f28 [diff] |
Revert "preloading: Firing pagehide when prerendering" This reverts commit 0e5d5e26ab69a64ff119153b940b85746055ad94. Reason for revert: Causes flaky failures of PrerenderBrowserTest.CancelOnSpeculationCandidateRemoved on many bots. On some bots, like Linux CFI, it seems to fail more than half the time. Bug: 392578265 Original change's description: > preloading: Firing pagehide when prerendering > > This CL makes prerender cancellation fire pagehide by calling > RenderFrameHostImpl::ClosePage when the prerendered page is > intentionally canceled (such as removing speculation rules, > not by failure). > Another CL https://crrev.com/c/6197678 is created as a follow-up to > support the new-tab cases. > > Bug: 353628449 > Change-Id: Ie2903ec3d0782c102181bccc3ec3d6910207481e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108648 > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Rakina Zata Amni <rakina@chromium.org> > Commit-Queue: Huanpo Lin <robertlin@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1411504} Bug: 353628449 Change-Id: I3c98c3fd04ad6fa3dd3749ea379512f261d95dfb No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6203506 Auto-Submit: Mark Pearson <mpearson@chromium.org> Owners-Override: Mark Pearson <mpearson@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/main@{#1411932}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.