| commit | 6875fbf83c5b0a2bf1b7ca96fc4a0614b2830172 | [log] [tgz] |
|---|---|---|
| author | Amanda Lin Dietz <aldietz@google.com> | Fri Oct 04 16:35:18 2024 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Oct 04 16:35:18 2024 |
| tree | f1b20b591dfbe946783b7d56659dae6fa33afee4 | |
| parent | be356c222a5b48024d4a1f800e4818299c76634d [diff] |
[FaceGaze] Fix key combos by avoiding rewriters if modifiers are present A fix was introduced in crrev.com/c/5804510 to skip rewriters on key presses to support Game Controls. It appears that modifiers get removed by some rewriter if use_rewriters = true when sending the synthetic key event, so this CL only send the synthetic key events with use_rewriters=true when there are no modifiers. There should be a follow up to check if Game Controls requires any key presses with modifiers and if there needs to be a different fix for Game Controls. AX-Relnotes: N/A Fixed: 371052581 Change-Id: I59954271c16fcaf0982e598508343b02cfb4df0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5908985 Commit-Queue: Amanda Lin Dietz <aldietz@google.com> Reviewed-by: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/main@{#1364276}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.