Google Git
Sign in
chromium / chromium / src / 68cf83e0e9a2d522f3478513d42e7981356f253a
commit68cf83e0e9a2d522f3478513d42e7981356f253a[log] [tgz]
authorPier-Alexandre Bouchard <pabouchard@google.com>Fri Aug 15 14:31:41 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Aug 15 14:31:41 2025
treee1814bed8a4a55d037aa500fe6a3f10338abcaf6
parentfa7c04c6a8ad108832487006d5c5eb6c473d9407 [diff]
[iOS] Ensure all search logos render on mini NTP background customization

Previously, third-party logos and doodles were fetched asynchronously.
By the time the fetch completed, the owning SearchEngineLogoMediator
instances were often deallocated, causing the logos to fail to appear in
the camera roll picker, preset gallery, and recent backgrounds.

This change updates the coordinators for each relevant view controller
to hold a strong ivar reference to their logo mediators. This ensures
mediators remain alive until the coordinator itself is deallocated,
rather than being released when the view controllers are deallocated.

Recent background: https://screenshot.googleplex.com/9MRp7QDtRzHfjne

Preset gallery: https://screenshot.googleplex.com/7yPpbWW4Q5wnokk

camera roll: https://screenshot.googleplex.com/829aovAStKYoVLB

Fixed: 437101833

Change-Id: I6966e35150f27bdd5f3b2cbfc370939231c3055a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6845704
Commit-Queue: Pier-Alexandre Bouchard <pabouchard@google.com>
Reviewed-by: Adam Arcaro <adamta@google.com>
Cr-Commit-Position: refs/heads/main@{#1501894}
10 files changed
tree: e1814bed8a4a55d037aa500fe6a3f10338abcaf6
  1. .gemini/
  2. .github/
  3. agents/
  4. android_webview/
  5. apps/
  6. ash/
  7. base/
  8. build/
  9. build_overrides/
  10. buildtools/
  11. cc/
  12. chrome/
  13. chromecast/
  14. chromeos/
  15. codelabs/
  16. components/
  17. content/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. fuchsia_web/
  24. gin/
  25. google_apis/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. net/
  34. pdf/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. clusterfuzz-data
  52. internal
  53. ios_internal
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .cursorignore
  60. .geminiignore
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. CRYPTO_OWNERS
  78. DEPS
  79. DIR_METADATA
  80. LICENSE
  81. LICENSE.chromium_os
  82. OWNERS
  83. PRESUBMIT.py
  84. PRESUBMIT_test.py
  85. PRESUBMIT_test_mocks.py
  86. README.md
  87. SECURITY_OWNERS
  88. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.