Google Git
Sign in
chromium / chromium / src / 6928655e4333bedfc48bc0b4f1325fc64eced5a6
commit6928655e4333bedfc48bc0b4f1325fc64eced5a6[log] [tgz]
authorYaron Friedman <yfriedman@chromium.org>Fri Sep 09 15:26:23 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Sep 09 15:26:23 2022
treec5d56b993d119caf703cd38fa520dc903100f4d4
parentf5e2a5ac23db8f3e041337bd665f775715b690a6 [diff]
[Jank] [a11y] Optimize browser UI thread time handling AX events

Introduces 2 potential optimizations behind a flag:
1) Between AxTree updates, cache IsLeafNode. Pprofs show this being a considerable percent of main thread time. Local instrumentation suggests cache hit rate of ~60% for typical usage
2) Augment GetTextContentUTF16 to be able to take a predicate and early-out instead of aggregating the full text of the tree below when you can make a decision earlier. This is motivated by example URLs like http://karpathy.github.io/2021/06/21/blockchain/ which end up aggregating thousands of strings just to answer whether it's non-empty, and then we do this many times.

Bug: 1352616
AX-Relnotes: n/a.
Change-Id: Idc8739c390a31661e20b1d1e36cef2b8c63aa4af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832831
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Mark Schillaci <mschillaci@google.com>
Cr-Commit-Position: refs/heads/main@{#1045120}
6 files changed
tree: c5d56b993d119caf703cd38fa520dc903100f4d4
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.