commit | 69334cca32f2c6a822ee7a752e1724f6e3064d71 | [log] [tgz] |
---|---|---|
author | Daniel Bratell <bratell@opera.com> | Tue Mar 26 11:07:45 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Mar 26 11:07:45 2019 |
tree | 563fba2d57503bcb45056e4e7da551201446e548 | |
parent | cba8a92e5fc473b4d23742c133cfd16d2e97552f [diff] |
Presubmit warning for std::to_string and error for std::shared_ptr std::to_string is one of the banned functions but people are not aware of that so a presubmit warning is needed. It is only a warning for std::string since it's already used and I don't want to trigger presubmit errors when someone changes something on the same line as an std::to_string(). std::shared_ptr has been banned for a while (use scoped_refptr) but it was brought to my attention because of std::weak_ptr from C++11 which builds on std::shared_ptr. These updates comes as most of the rest of C++11 is removed from the ban list and only some very few functions/types remain banned. See: https://groups.google.com/a/chromium.org/d/msgid/cxx/CAAHOzFDHbjTfGH0wktnDryONBEEyG2O9o-CCMVWuTYFokjrSUw%40mail.gmail.com Change-Id: I9fb1450ee76046cb842cd5a64a55d2cc977492b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535872 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#644250}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .