commit | 6936aed866f955e88de17819a79faa9f0c1fb851 | [log] [tgz] |
---|---|---|
author | jhtin <jhtin@chromium.org> | Mon Sep 12 05:21:34 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Sep 12 05:21:34 2022 |
tree | 20e495cbe7b54d6f1beca605f992339fea79d458 | |
parent | 48aa47736b83690c2768091822fa42d20d94f95c [diff] |
longpress diacritics: Make timer trigger based on keyevent dom code This fixes issue where if you type in this particular sequence: 1) SHIFT DOWN 2) KEY DOWN "a" (with SHIFT modifier, char = "A") 3) SHIFT UP 3) KEY UP "a" (without SHIFT modifier, char = "a") The diacritics timer will think that KEY DOWN "a" (with SHIFT modifier) was never released, since we only used the character created by each event. This will then trigger a diacritics window 500ms in the future for "A". Making the timer trigger based on domcode which correspond to the actual physical keys fixes this issue, and it'll dismiss as intended. Fixed: b/242933168 Change-Id: If84428a4308134439ce6d468d84469922225b93e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3881626 Reviewed-by: Jing Wang <jiwan@chromium.org> Commit-Queue: jhtin <jhtin@chromium.org> Reviewed-by: Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/main@{#1045675}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.