Google Git
Sign in
chromium / chromium / src / 6956ee0f197e14b01d70d9cec63ea2cfc421e65e
commit6956ee0f197e14b01d70d9cec63ea2cfc421e65e[log] [tgz]
authorJoey Arhar <jarhar@chromium.org>Wed Jan 24 20:19:40 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jan 24 20:19:40 2024
tree946646cdeef905468b5a0e9e6c3cb8be7df0f6a9
parent04fa180dc7aea16a905f79c715dc2ee5cc6f742b [diff]
Improve XML namespace error handling

A change in libxml which I will merge after this patch regressed some of
our tests. This patch implements fixes to make the libxml change work
without actually applying the libxml change. Merging this first behind a
flag without the libxml change will allow us to safely release the new
behavior. I will merge the libxml changes after the next branch point.

These changes were recommended by the libxml maintainer here:
https://gitlab.gnome.org/GNOME/libxml2/-/issues/653

The first fix is to null terminate the strings in
g_shared_xhtml_entity_result.

The second fix is to explicitly emit errors when attributes are parsed
which use a namespace that doesn't exist. We have a test for this and
before the libxml commit we had some odd behavior which would end up
saying that the xml was malformed which isn't actually the case.

Change-Id: I1602bf252f6ab9188ed8548abfe1386fc2141116
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5174719
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1251632}
7 files changed
tree: 946646cdeef905468b5a0e9e6c3cb8be7df0f6a9
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.