commit | 69dec1bb9bc77ce0d326ca0bcc76873b835570a9 | [log] [tgz] |
---|---|---|
author | Clement Yan <clamclamyan@google.com> | Thu Nov 10 05:15:49 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Nov 10 05:15:49 2022 |
tree | c6fbc9ea5737a83674e531e736dc98eaca826a23 | |
parent | 1a89c18bf0b54ebdb8602ea314c7a52004f2f891 [diff] |
[WebUI] Migrate NearbyShareUI to WebUIConfig Context: Currently WebUI properties, e.g. CSPs, requesting schemes, host, mojo, etc. are stored in WebUIControllers themselves or in separate lists like IsWebUIAllowedToMakeNetworkRequests. The lifetime of a WebUIController is bound to the frame, which makes it hard to use for some use cases where the WebUIController hasn't been created yet. A non-dynamically allocated class where clients could query a WebUI's properties would be easier to use and audit. WebUIConfig is a class that stores properties of WebUIs. For now the properties are 1. the WebUI's origin, 2. if the WebUI is enabled, and 3. GetURLDataSource() method for service worker initialization. In the future this class could include information like CSPs, if we should enable Mojo, if we should enable chrome.send(), if we should allow network requests, URLDataSource, etc. Bug: 1317510 Change-Id: I6611735b62ddb4e9fb36824e2f42556c47ac6259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4015342 Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org> Commit-Queue: Clement Yan <clamclamyan@google.com> Cr-Commit-Position: refs/heads/main@{#1069593}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.