commit | 69e8f3069ac190128d51151f3effb92060ce9c03 | [log] [tgz] |
---|---|---|
author | Dale Curtis <dalecurtis@chromium.org> | Wed May 22 07:36:58 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed May 22 07:36:58 2019 |
tree | baf3c95aca0df6597549ce915eb9f99624845d23 | |
parent | 4dc6fad728c2b87d27ab5c5ef757c687c3bc5bf5 [diff] |
Always preroll unless we've reached kReadyStateHaveFutureData. Even though we'd like to stop earlier if an element isn't playing, we can't know if the page is waiting for canplaythrough, so we must buffer until that point so the event fires. This is a partial revert of d71061f027f18f15d2d197681a49154f6c14d531's behavior. We still handle play/pause at kReadyStateHaveMetaData, but unfortunately the preroll attempt is still needed. TODO: Instead of prerolling non-playing tags past metadata, we might instead signal kReadyStateHaveFutureData upon suspend to avoid wasting resources. TODO: Clearly this behavior is missing a test. :| BUG=879406 TBR=sandersd Change-Id: I967ab2c4f8297f8f2e7f9ea91dab7e04f9b88880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623668 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#662084}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .