Google Git
Sign in
chromium / chromium / src / 69edb14bbb0264109aac78b21c423cd49f95c2e7
commit69edb14bbb0264109aac78b21c423cd49f95c2e7[log] [tgz]
authorXinyi Ji <xinyiji@google.com>Thu Jun 08 17:58:34 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jun 08 17:58:34 2023
tree552e3180b173504e09f2a32d4fdcb0a3616503d6
parentab4e1ed7c3447fbcaad9f16cb51a154537b7a5b7 [diff]
[StartTablet] Fix bug about NTP thumbnail with the visibility of Single Tab Card

This CL resolves an issue related to the NTP thumbnail. Previously, after closing the tab to track in the grid tab switcher, the NTP thumbnail would remain unchanged no matter how many times navigating between the NTP and the grid tab switcher. Therefore, there is a noticeable transition of the single tab card disappearing every time we navigate to the NTP from the grid tab switcher. The problem is demonstrated in the following video: https://drive.google.com/file/d/15acBOOBaYa6O4rrK9wu8PWV3uBG53kQ-/view?usp=sharing&resourcekey=0-FSrKXxNU2bhdMwaS_iTscw

This CL introduces a capture of the NTP thumbnail process. This process is triggered when the single tab card disappears in the NTP and the user navigates back to the grid tab switcher. Therefore, the noticeable transition of the single tab card disappearing will only happen the first time when we navigate back to the NTP from the grid tab switcher.

Bug: 1451915
Change-Id: If1e7f47c01df61aa3237a4564e029c97b80322d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4592950
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Commit-Queue: Xinyi Ji <xinyiji@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1154986}
7 files changed
tree: 552e3180b173504e09f2a32d4fdcb0a3616503d6
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.