Google Git
Sign in
chromium / chromium / src / 69f0ef63b068cf49abe69bf65ed5a19e29a012e3
commit69f0ef63b068cf49abe69bf65ed5a19e29a012e3[log] [tgz]
authorAaron Krajeski <aaronhk@chromium.org>Fri Jan 21 17:34:34 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jan 21 17:34:34 2022
treec9066f6749a3656f6870db9fe89cc2b58befcbd2
parent481e62b09749992b75592c30e0a190eb74fb7851 [diff]
Reverse logic for willReadFrequently flag

With the New Canvas2D API (crbug.com/1201359) there is one instance
where we are changing existent behavior. Previously, an accelerated
canvas would be turned into a software canvas upon any readback. Now
developers have explicit control with the willReadFrequently creation
attribute:
https://github.com/fserb/canvas2D/blob/master/spec/will-read-frequently.md
  Now accelerated canvases will remain accelerated on readback. This
will result in performance regressions for websites that were relying on
the old behavior until they add {willReadFrequently: true} to their
context creation.

  This flag allows us to roll out the feature slowly and measure
performance regressions with a finch experiment. It needs to be part of
content/public/common/content_switch_dependent_feature_overrides.cc
because a couple of tests expect canvas readback to not de-accelerate
canvases.

Bug: 1288118
Change-Id: I2d051f30b0df617e60df756626ad66e1255f4ec3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3402979
Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#961951}
6 files changed
tree: c9066f6749a3656f6870db9fe89cc2b58befcbd2
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.