commit | 69f9da6500b8a002c5ce00539911064564c03431 | [log] [tgz] |
---|---|---|
author | Sven Zheng <svenzheng@google.com> | Tue Oct 15 19:36:43 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Oct 15 19:36:43 2024 |
tree | 8e8fb0fcb203cce6682c53fc51b454ce415c24f5 | |
parent | 8d504999cc716c5af4611a6b8ab6769bc290f0fa [diff] |
Reland "Show commandline variations on chrome://version page" This is a reland of commit 6c54aaa66c3d4647e3034bca6716ac8e08e34266 See ps1 and latest ps for differences. In this reland, the variations is base64 encoded if user go to chrome://version. No changes for chrome://version?show-variations-cmd. Test: Tested on Linux, Mac, iOS for both pages. Tested the encoded string can be decoded using base64 in bash. Original change's description: > Show commandline variations on chrome://version page > > Launch bug: https://launch.corp.google.com/launch/4347542. > Show commandline variations on the chrome://version page > so it would be easier for user to report variations. > > Add a truncated commandline variations string, with a copy > button at the end. Screenshot can be seen in the png file. > > iOS specific: chrome://version/?show-variations-cmd didn't > work. Seems like a bug. Also fixed this issue that visiting > the link would show full variations commandline. > > iOS. Also tested screen reading works on Linux, Mac. > > Bug: b/352162989 > Test: Tested the functionality works on Windows, Linux, Mac, > Change-Id: I7b289afc057c3790a9250f3db5df964f224ceb35 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5874716 > Commit-Queue: Sven Zheng <svenzheng@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1363247} Bug: b/352162989 Change-Id: I4290f48708359008ed670a806a85af48a9753f73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5918046 Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/main@{#1368949}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.