Google Git
Sign in
chromium / chromium / src / 6a8812c1d1315278cf0e58b202722462a52da310
commit6a8812c1d1315278cf0e58b202722462a52da310[log] [tgz]
authorYoichi Osato <yoichio@chromium.org>Mon Nov 28 02:20:35 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Nov 28 02:20:35 2022
treeadc177708c6373724f60d927a6471ba8721e0dfd
parent4cf670e07e8312127cf6f3796c1fee376a0066d4 [diff]
[CodeHealth] Remove calls to Value::GetAsDictionary (extensions/browser/api_unittest.h)

This CL removes GetAsDictionary as a starting point, but also
opportunistically migrates away from other deprecated base::Value APIs.

Specially this CL removes RunFunctionAndReturnDictionary and
RunFunctionAndReturnList because the return value's types are checked at the callers.

Bug: 1187011
Change-Id: I92e6032497119b9775223965b26ce663c196ab5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4053767
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Auto-Submit: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1076043}
10 files changed
tree: adc177708c6373724f60d927a6471ba8721e0dfd
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.