Google Git
Sign in
chromium / chromium / src / 6aa377d5210b297bfa27c074abafad3d7863566f
commit6aa377d5210b297bfa27c074abafad3d7863566f[log] [tgz]
authorAri Chivukula <arichiv@chromium.org>Tue Jun 07 12:01:38 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jun 07 12:01:38 2022
treec7d594a818d9beb2d942f36d9e655003b6b6a6e7
parent372115c3a34f3ea9f83151617a34145da0f5fdfe [diff]
{M103 PICK} [Fix UserAgentReduction Policy] (2) Fix GetProductAndVersion

This resolves an issue where the user agent reduction enterprise policy
is not respected due to GetProductAndVersion only checking the feature.
The policy is propagated from
ChromeContentBrowserClient::GetUserAgentBasedOnPolicy downward.
The specific issue is tested in UserAgentUtilsTest::GetProductAndVersion
under item 4c (policy force disabled overrides the feature being
enabled).

This CL is part of a series:
(1) Make ForceMajorVersionToMinorPosition a class enum
(2) Fix GetProductAndVersion

(cherry picked from commit 8bb92c3333d1ad4a9dc72671a7968458b72b89b3)

Bug: 1330588
Change-Id: I6f2dfcf8ea9e9c217c1562f4efca2df24de613f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3684269
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: Victor Tan <victortan@chromium.org>
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
Quick-Run: Ari Chivukula <arichiv@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1010140}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3687390
Cr-Commit-Position: refs/branch-heads/5060@{#636}
Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
8 files changed
tree: c7d594a818d9beb2d942f36d9e655003b6b6a6e7
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_webengine/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.