Report "can make payment" only when `show()` will not fail Before this patch, `AndroidPaymentAppFinder` called `mFactoryDelegate.onCanMakePaymentCalculated(true)` whenever it found at least one app, but then discarded the apps whose `IS_READY_TO_PAY` service returned `false` or failed to bind. As a result, the `PaymentRequest.canMakePayment()` call could return `true`, but invoking `PaymentRequest.show()` returned `NotSupportedError`. A website could draw a payment button, but clicking this button would not launch the app. This patch changes `AndroidPaymentAppFinder` to call `mFactoryDelegate.onCanMakePaymentCalculated(true)` only if it also calls `mFactoryDelegate.onPaymentAppCreated(app)`. After this patch, if the `PaymentRequest.show()` method will return `NotSupportedError`, then the `PaymentRequest.canMakePayment()` method will return `false`. Fixed: b:440022389 Change-Id: I276bd0c1718bbd305e0296cd87b93aaa8c69da99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6873971 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by: Slobodan Pejic <slobodan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1508061}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.