Google Git
Sign in
chromium / chromium / src / d7fc6d05d36c638d81d98280610c5d6ff43ffb8a
commitd7fc6d05d36c638d81d98280610c5d6ff43ffb8a[log] [tgz]
authorKevin McNee <mcnee@chromium.org>Tue Feb 08 21:21:50 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Feb 08 21:21:50 2022
tree349f9527af6a753075fe2d55b66f262838339e87
parentf65e00fb798a079e40c153a0388f1ecb326a45bf [diff]
Don't iterate RenderFrameHosts when the WebContents is being destroyed

During WebContents destruction, its main RFH becomes null. Attempting
to iterate over RenderFrameHosts after that point would lead to a
crash.

We also remove part of a unit test that was simulating behaviour that
we're now asserting can't happen (hiding a WebContents that's being
destroyed).

Bug: 1290465
Change-Id: I91882d918146c463d7b3ff5493af6e7d60a5ca89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3415711
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Charles Reis <creis@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/main@{#968548}
5 files changed
tree: 349f9527af6a753075fe2d55b66f262838339e87
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.