Google Git
Sign in
chromium / chromium / src / 6ae0104665e1b14f77f750a441488f26dd9b1ac0
commit6ae0104665e1b14f77f750a441488f26dd9b1ac0[log] [tgz]
authorMikel Astiz <mastiz@chromium.org>Wed Mar 26 14:35:45 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Mar 26 14:35:45 2025
tree1272613cf7ca4af02d6cf005780192d9d1067c12
parent523381525ebaf34c201f95652415ae9cc967358c [diff]
[sync] Use task-posting for datatype errors only when needed

Task-posting when reporting errors via DataTypeController is somewhat
arbitrary, as it becomes obvious in unit-tests (see removed TODOs in
this patch).

Instead, the real case where task-posting is needed is
ProxyDataTypeControllerDelegate, whose only purpose is to deal with
cross-sequence propagation of API calls.

The side effect and risk with this patch is that some API calls, such
as `DataTypeController::LoadModels()`, could exhibit a synchronous
behavior for errors. This seems reasonable, because this function
does already report success cases synchronously (also documented
explicitly in the API), and error-handling code in [1] also has some
precedents for synchronous codepaths.

[1] https://source.chromium.org/chromium/chromium/src/+/main:components/sync/service/model_load_manager.cc;l=295;drc=87c3217dc3fec0f441b68f33d339b7f3a707b11d

Change-Id: I5d1d65e4ffedc3ff9a54f6722ddbc6ac0db4411c
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6394376
Reviewed-by: Mahmoud Rashad <mmrashad@google.com>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1438100}
3 files changed
tree: 1272613cf7ca4af02d6cf005780192d9d1067c12
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.