Google Git
Sign in
chromium / chromium / src / 6b18cded5aad3afb9231ee4381a2770d1a1c70eb
commit6b18cded5aad3afb9231ee4381a2770d1a1c70eb[log] [tgz]
authorCole Horvitz <colehorvitz@chromium.org>Fri Apr 21 19:16:53 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Apr 21 19:16:53 2023
treeea26ed4af0c37e438346e0b85fd4492ad99c3ec0
parent40f696586b2271e17ff50269b3d8ced27435540e [diff]
cr-link-row: Depend on loadTimeData for external links.

This changes cr-link-row to use loadTimeData for external links,
in order to use the default "opens in new tab" language. This removes
the need for users of cr-link-row to pass in the
button-aria-description manually. Instead, the consumer only needs to
register a opensInNewTab string in its data source.

buttonAriaDescription may still be passed as an attribute to override
the default behavior. Existing usages which do not already pass in or
register a string were updated to do so.

Note that this CL effectively changes the way in which cr-elements
should be used, as previously i18n dependencies were not permitted.

Bug: 1433382
Change-Id: I9ba38717b62ac6413c852c2b109c19b0f8f09b85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4429590
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Cole Horvitz <colehorvitz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1133960}
9 files changed
tree: ea26ed4af0c37e438346e0b85fd4492ad99c3ec0
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.