commit | 6b33075049863fa9149a6a6f28c6ab6262169cb5 | [log] [tgz] |
---|---|---|
author | Fumitoshi Ukai <ukai@google.com> | Thu Apr 24 08:05:19 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Apr 24 08:05:19 2025 |
tree | cf6b77b0465261c6cdce76d9c2085f94be79de6d | |
parent | aa1055b682f98a53fb84f234c7d1715ed4d82167 [diff] |
fix missing deps for generated_api_registration.o ``` In file included from gen/chrome/browser/extensions/api/generated_api_registration.cc:16: In file included from ../../chrome/browser/extensions/api/experimental_ai_data/experimental_ai_data_api.h:9: In file included from ../../chrome/browser/ai/ai_data_keyed_service.h:23: In file included from ../../chrome/browser/glic/host/context/glic_page_context_fetcher.h:15: ``` //chrome/browser/extensions/api:api_registration doesn't have dependency to //chrome/browser/extensions/api/experimental_ai_data https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/extensions/api/BUILD.gn;l=107 but ``` ERROR Dependency cycle: //chrome/browser/extensions:extensions -> //chrome/browser/extensions/api:api_registration -> //chrome/browser/extensions/api/experimental_ai_data:experimental_ai_data -> //chrome/browser/extensions:extensions ``` so, add //chrome/browser/ai instead Bug: 412521228 Change-Id: I78ace9e4a9662aafea1245927d7beb6701a57600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6486907 Auto-Submit: Fumitoshi Ukai <ukai@google.com> Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Fumitoshi Ukai <ukai@google.com> Cr-Commit-Position: refs/heads/main@{#1450989}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.