Google Git
Sign in
chromium / chromium / src / 6b9fb62ad4bbf7a516e5cf99ccd367a6d4c19b82
commit6b9fb62ad4bbf7a516e5cf99ccd367a6d4c19b82[log] [tgz]
authorPu Shi <pushi@google.com>Fri Apr 22 19:00:20 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Apr 22 19:00:20 2022
treec668ac56603eafdceef060e27d91d4c48f844a4a
parent73ee5b16939b97ad8e9ddc36269c4277aa9b54a0 [diff]
[Nearby] Fix crash caused by base::Unretained during shutdown

In the ScheduledExecutor class the use of base::Unretained(this) in
a callback caused a crash during the shutdown process when the object
has been destroyed. Replacing them with weak pointers will make sure
the callback will not run if the object has been destroyed.

Bug:1316846
TEST = manually tested and passed unit tests

Change-Id: Ia1df0fe5f4d190ce247eb3a38b3983d54a245855
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3600852
Reviewed-by: Josh Nohle <nohle@chromium.org>
Commit-Queue: Pu Shi <pushi@google.com>
Cr-Commit-Position: refs/heads/main@{#995295}
1 file changed
tree: c668ac56603eafdceef060e27d91d4c48f844a4a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.