Google Git
Sign in
chromium / chromium / src / 6baf367e2052efef25179c23261237359779d05a
commit6baf367e2052efef25179c23261237359779d05a[log] [tgz]
authorShakti Sahu <shaktisahu@chromium.org>Thu Nov 14 02:56:00 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Nov 14 02:56:00 2024
tree8435e38f9024802147be599c706c02f08ab2f478
parenta82da32cac1668111316d5885e34d2be15ee81a0 [diff]
[TG Sync] TGSS should wait for people group data before notifying UI

When a shared tab group is to be shown for the first time
(regardless whether it's on creator's device or on join flow or
creator's other device), the tab group should not be shown on the
UI if the corresponding people group isn't available on the device
yet. Since the people group and the shared tab group are two
different sync entities received as different messages from sync,
we don't have control over them. Hence, a better solutin is to
have TabGroupSyncService wait for the people group to be available
on the DataSharingService. Since we don't want to create direct
dependency of TGSS on DSS, this CL proposes another class (
CollaborationFinder) to be injected into TGSS on construction
which will be responsible for providing people group related
information. This interface will have a query API and a observer
API about people group availability.

Bug: 377978696
Change-Id: I85da1d171efe66054320e33d534ca4e753cbac96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6009120
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1382771}
22 files changed
tree: 8435e38f9024802147be599c706c02f08ab2f478
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.