Google GitGoogle Git
Sign in
chromium/chromium/src/6bbf19c7169fe6c43cf4c8f5da590c027ea22b86
commit
6bbf19c7169fe6c43cf4c8f5da590c027ea22b86
[log]
author
Georg Neis <neis@chromium.org>
Tue May 09 04:02:55 2023
committer
Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>
Tue May 09 04:02:55 2023
tree
4e16105df777fd660fc0bd96b5ed6671bd4c5b47
parent
b40a1440782d7b5d2e34de1d1604f0bc65f5b967 [diff]
crosapi: Fix url handling bug

This fixes a crash on Lacros omnibar-navigation to os://flags/ or
chrome://scanning//, in the form of a small change that is easy to
back-merge: only launch the OS_URL_HANDLER app if the target URL
does not already belong to a capturing SWA.

Regression tests are contained in a larger followup-CL that aims to
make this component less adhoc and more robust in several ways:
https://chromium-review.googlesource.com/c/chromium/src/+/4482283

Bug: chromium:1432050
Change-Id: I15fa0f533fad2d89cd2f3a6c6751e570a1d7c4a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4487123
Reviewed-by: Dana Fried <dfried@chromium.org>
Reviewed-by: Jiewei Qian <qjw@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1141180}
3 files changed
tree: 4e16105df777fd660fc0bd96b5ed6671bd4c5b47
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.