Google Git
Sign in
chromium / chromium / src / 6bd941b67ab326925457b4e8ff05d79f8b9a7489
commit6bd941b67ab326925457b4e8ff05d79f8b9a7489[log] [tgz]
authorElad Alon <eladalon@chromium.org>Sat Feb 20 15:20:16 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Sat Feb 20 15:20:16 2021
tree74c35d0f12385c4c2afa16494a6956860e1cbbb4
parent0afcd9224bd882502fa835678e2c2cf40d49599b [diff]
Add the option of "Current Tab" to the media picker

Previously, getCurrentBrowserContextMedia (gated by command line flag)
resulted in a confirmation-only dialog. This CL changes things so that
the confirmation-only dialog would only be shown if the gCBCM is called
under certain (TBD) conditions; otherwise, the user would have to
explicitly select the tab. However, the user will be given a quicker way
to explicitly selecting the current tab, through a new dialog-tab in the
media picker, which shows a live-preview of the current tab (the one
from which gCBCM is called).

Googlers: Design docs and mocks are available under go/gcbcm.

TBR=grt@chromium.org

Bug: 1136942
Change-Id: I066c84a6875e1bd8afcda97e083b6a29a0a0fdaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2704116
Reviewed-by: Elad Alon <eladalon@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elad Alon <eladalon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#856101}
28 files changed
tree: 74c35d0f12385c4c2afa16494a6956860e1cbbb4
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.