Remove HasCommitted check in BookmarkTabHelper::DidFinishNavigation We need to update the starred state even when the navigation finishes without committing, because we expect the bookmark star should always show whether the current committed URL is bookmarked or not. As a first step, this CL removes the check of committing in BookmarkTabHelper::DidFinishNavigation, then adds a test to ensure that the starred state is false on the same document navigation. TEST: BookmarkBrowsertest.SameDocumentNavigation Bug: 1329720 Change-Id: I49e3d0e6f7d9f6086cc01264c582c874656cf605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3649399 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/main@{#1011241}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.