commit 6c5ff51270cd0995e0bad81b51b2edd1e62f312a
author mlcui <mlcui@google.com> Sat Nov 09 00:10:41 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Sat Nov 09 00:10:41 2024
tree ace4038ba9d6eb9bd3dead32a985f4e6629a19f1
parent f93bc2b7f31568be51c4eda9f67aaec0a17b64e7

scanner: Fix actions for stale regions appearing in new regions

To do so, we introduce an "image search token" - a weak pointer - which
is invalidated whenever the capture parameters (type, source, bounds -
excluding window) change during a session.

Using this, we get an image search token when
`CaptureModeController::PerformImageSearch()` is called, and pass it
down to `CaptureModeController::OnImageCapturedForSearch()`,
`CaptureModeController::OnTextDetectionComplete()` and
`CaptureModeController::OnScannerActionsFetched()`. If at any point the
image search token becomes invalidated, either the region changed or the
session shut down, so we abort.

This mitigates the issues coming from running the latter two
aforementioned methods on stale regions - specifically, adding multiple
"copy text" / "smart actions" buttons, and adding multiple Scanner
action buttons respectively. The manual checks for stale regions and
sessions are now a weak pointer check, and handles the case when a new
region has the same bounds as an old region.

Fixed: b:377602345, b:377570476, b:376168016
Change-Id: I6a6a2100a095ee800d450825a2d333925c7f4b5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999032
Auto-Submit: Michael Cui <mlcui@google.com>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Michael Cui <mlcui@google.com>
Cr-Commit-Position: refs/heads/main@{#1380712}