Google Git
Sign in
chromium / chromium / src / 6c836551b1948faf97d12fd29fad9bb165df048b
commit6c836551b1948faf97d12fd29fad9bb165df048b[log] [tgz]
authorVictor Hugo Vianna Silva <victorvianna@google.com>Wed Jun 05 15:17:38 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jun 05 15:17:38 2024
treeb1bc3d3ed130d745aafec59f69ac023b74db36e8
parente343be86ab431f04000f600e862e5713cc3da68f [diff]
Fix incorrect cast when passing Java SyncService to native

isGmsCoreUpdateRequired() passes a SyncService to the native side.
https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/password_manager/android/java/src/org/chromium/chrome/browser/password_manager/PasswordManagerUtilBridge.java;l=94;drc=2cd3cfc737691c6f54b00b650002e6580d67b9e7

But the native side assumes the object is of type SyncServiceImpl.
https://source.chromium.org/chromium/chromium/src/+/main:components/sync/android/sync_service_android_bridge.cc;l=101;drc=2cd3cfc737691c6f54b00b650002e6580d67b9e7

So that causes crashes when FakeSyncServiceImpl or any kind of
mock is used.

Solution: move getNativeSyncServiceAndroidBridge() from the Impl to
the interface.

Bug: 344609691
Change-Id: I5758f39220c4272b951a7d1e80f151688c73b780
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5600604
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1310634}
6 files changed
tree: b1bc3d3ed130d745aafec59f69ac023b74db36e8
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.