commit | 6cfbf972e54fddbdc949bb063a9d5dc1c8924414 | [log] [tgz] |
---|---|---|
author | Sahir Vellani <sahir.vellani@microsoft.com> | Thu Sep 05 20:27:27 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Sep 05 20:27:27 2024 |
tree | ad0220900cbf79390155670ac61f24311842f054 | |
parent | 661e210d024a72034d038ca59d19dcfe4d7b3015 [diff] |
[Delegated Ink] Remove check for exact coordinates when erasing point GPU process crashes because of the following check: CHECK(points_to_draw.front().MatchesDelegatedInkMetadata(metadata)) in FilterEvents(). The reason this check is hit is because DelegatedInkPointRendererBase gets multiple points with the same location but different timestamps. It is found that the premise is acceptable, as this normally repros during a pointer down, where the pointer is stationary for a little while. The check hits because the points older than metadata are not erased if they have the same location as the metadata. This condition does not need to exist and is removed. Furthermore, the check is converted into a dump without crash to prevent a negative user experience. Bug: 364821288 Change-Id: I8b9e2ec6f437f2e42a3c3f0f7ce989b544bc9bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5840268 Reviewed-by: Olga Gerchikov <gerchiko@microsoft.com> Reviewed-by: Vladimir Levin <vmpstr@chromium.org> Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Reviewed-by: Gaston Rodriguez <gastonr@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1351669}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.