Google Git
Sign in
chromium / chromium / src / 6d222dc5d3cbac3fc214cce2c212e819a0f0e1c4
commit6d222dc5d3cbac3fc214cce2c212e819a0f0e1c4[log] [tgz]
authorElad Alon <eladalon@chromium.org>Mon May 06 18:34:27 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon May 06 18:34:27 2024
treed9dd2d49ed6f156e31843f7a17ae3b5ed9c89aa0
parent167fea3329c388e6d7630e499af2968995317542 [diff]
[m125] Fix MediaStreamVideoCapturerSource no-return-after-failure

In MediaStreamVideoCapturerSource, if SendWheel() or SetZoomLevel()
encountered a missing device ID, they invoke the callback,
but they failed to return immediately. Instead, they passed that
moved-from callback onwards to the MediaStreamDispatcherHost.

This CL fixes this issue.

(cherry picked from commit 780e58ee6c33b9d54ba3222c00a9b96f36ef600c)

Bug: 337847746
Change-Id: I29ddbf95d3fde50357a5190049db1175bffcadcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5497319
Auto-Submit: Elad Alon <eladalon@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Elad Alon <eladalon@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1293993}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5501236
Reviewed-by: Tove Petersson <tovep@chromium.org>
Cr-Commit-Position: refs/branch-heads/6422@{#726}
Cr-Branched-From: 9012208d0ce02e0cf0adb9b62558627c356f3278-refs/heads/main@{#1287751}
3 files changed
tree: d9dd2d49ed6f156e31843f7a17ae3b5ed9c89aa0
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.