commit | 6d28211e021243b99be2bee38939ec2c20692580 | [log] [tgz] |
---|---|---|
author | Daniel Bratell <bratell@opera.com> | Tue Mar 26 16:57:33 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Mar 26 16:57:33 2019 |
tree | 7d2918dc94ea250484f0e83e3fe05c6bc52dbd43 | |
parent | 76c50adafa2237011144c9a993b2b34b1118b03f [diff] |
Add missing components/policy build dependencies Generated files in components/policy used header files that they didn't depend on. This oversight caused errors when running gn check --check-generated (brand new gn feature!) For instance: ERROR at //out/Default/gen/components/policy/policy_constants.h:14:11: Include not allowed. #include "components/policy/core/common/policy_details.h" ^--------------------------------------------- It is not in any dependency of //components/policy:generated The include file is in the target(s): //components/policy/core/common:internal which should somehow be reachable. This CL fixes those errors by listing/allowing necessary dependencies. An alternative would be to extract policy_details.h and policy_map.h into a new build target, including everything they depend on. I didn't investigate how much work that is because of time constraints. Bug: 938893 Change-Id: I69775047ae70f15138ad0754f4c4d51bd02c7530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527534 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#644380}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .