Move more Omaha tests to become Robolectric tests

This change moves the ExponentialBackoffSchedulerTest,
RequestGeneratorTest, and OmahaBaseTest to be based on Robolectric.

Multiple files depended on MockExponentialBackoffScheduler,
MockRequestGenerator, and AttributeFinder, so instead of doing
gymnastics with temporary putting these in a shared GN test support
target, these test fixes are submitted together.

Using Robolectric requires stopping all usage of AdvancedMockContext,
though InMemorySharedPreferencesContext is OK. However, Robolectric
provides similar functionality as AdvancedMockContext through
RuntimeEnvironment.getApplication().

The OmahaBaseTest directly invokes checking for updates, which should
not be invoked on the main thread. However, in this very targeted test
it is OK to do so, but the thread asserts still fail. This change
therefore changes to do the assert through TestUtil, and creates
an AutoCloseable to ensure as little test code as possible is affected
by disabling thread asserts.

R=waffles@chromium.org

Bug: 1332190, 1332191, 1332192
Change-Id: I6687ec2bff7180ba3a4566ebe9b8a78f34f11ada
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3705785
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1014921}
12 files changed
tree: 9b1b086ee0b13322d9c77e02dc5398adaa4c49b9
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_web/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.