Google Git
Sign in
chromium / chromium / src / 6d6d1f56fb4f289831f89784d334fcd4df52a12e
commit6d6d1f56fb4f289831f89784d334fcd4df52a12e[log] [tgz]
authorJacobo Aragunde Pérez <jaragunde@igalia.com>Wed Jan 11 12:43:45 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jan 11 12:43:45 2023
tree0dbb959243c3d6b0d43558eefc1a4a68104663ae
parent68391223230159b067a2d9f1004249a627509bd9 [diff]
Append file name in <input type="file"> accessible name.

According to code comments, the file name was hidden for historical
reasons but that's not exactly true, we expose it in unlabeled
controls. So this information is necessary for accessibility users,
it's already visible and there are mitigations for privacy concerns
related to exposing the path, there is no reason to conceal it.

We currently expose this type of control as a button which has a name
that can be computed from different sources. We decided to append the
file name to the computed name of the label.

Bug: 1147028
Change-Id: I5d2852e6be63fbecc6fd97d58332cc6a0a1b4f14
AX-relnotes: Expose file name in <input type=file>.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4063689
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1091274}
44 files changed
tree: 0dbb959243c3d6b0d43558eefc1a4a68104663ae
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.