Google Git
Sign in
chromium / chromium / src / 6d86aae3cb30ce77fd645209a9b76fd1b4dfc0f8
commit6d86aae3cb30ce77fd645209a9b76fd1b4dfc0f8[log] [tgz]
authorAlexander Hendrich <hendrich@chromium.org>Mon Jun 20 14:44:35 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Jun 20 14:44:35 2022
treef8ec7fc6ff136c286a681e2e8fb6dd5174950259
parent90850305cd79f9a4527966aff72252d9a33412e6 [diff]
Fix test case + sample for SendDownloadToCloudEnterpriseConnector

The `service_provider` in the `SendDownloadToCloudEnterpriseConnector`
policy must match one of the keys from `GetServiceProviderConfig()`,
otherwise it will crash at
https://crsrc.org/c/chrome/browser/enterprise/connectors/file_system/service_settings.cc;drc=169c6cc102b39295a5bfe2f2a176b42b1c2fe2c4;l=29.

This is likely something that requires more robust parsing or error
handling.

This was discovered as part of re-enabling the flaky PolicyPrefsTest.PolicyToPrefsMapping, which uses the test cases provided in policy_test_cases.json.

Bug: b/226560946

Change-Id: Ifcdb9ee12c598f4bd7c544b97a4589af0d4077c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3714130
Auto-Submit: Alexander Hendrich <hendrich@chromium.org>
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Dominique Fauteux-Chapleau <domfc@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1015895}
2 files changed
tree: f8ec7fc6ff136c286a681e2e8fb6dd5174950259
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_web/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.