Google Git
Sign in
chromium / chromium / src / 6d9e682a0213416d27167da65ad15753a5457780
commit6d9e682a0213416d27167da65ad15753a5457780[log] [tgz]
authorSteve Kobes <skobes@chromium.org>Thu Jan 26 22:56:12 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jan 26 22:56:12 2023
tree84b9c125e94a5d61ecd6a9fc943c304a9f34f924
parentb4e51b9e48e6b66021cf595f2a48f49c2ae0521a [diff]
Fix scrolling in preserve-3d in non-overflowing OOPIF.

The post-unification cc hit test doesn't find a scroller inside a
transform-style: preserve-3d container, because the sorting context id
isn't set on the scrolling contents layer.

This patch addresses the issue by making IsInitialScrollHitTestReliable
reject the hit test.  The main thread identifies the correct scroller.
This matches how it is already working for non-OOPIF.

A TODO in LayerTreeImpl is added for making the cc hit test work.

Bug: 1407697
Change-Id: I1d9652a49f88c9c17111b6f716c1dad8f9f0fc23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4193135
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1097660}
4 files changed
tree: 84b9c125e94a5d61ecd6a9fc943c304a9f34f924
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.