commit | 6dcf7e9dc54105f8e38df5ab760b6c3d3c356004 | [log] [tgz] |
---|---|---|
author | Rouslan Solomakhin <rouslan@chromium.org> | Fri Sep 18 16:58:23 2020 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Sep 18 16:58:23 2020 |
tree | 642df73cfa6a60c914141ceb502e5624a10d864b | |
parent | f719e12ed7d4cc61602c4c07cebc7a8e9c7789ee [diff] |
[Web Contents] Delete authenticator before render frame. Before this patch, it was possible to delete the render frame host before the secure payment confirmation app, which owned an instance of an authenticator that must outlive the render frame host. This caused a crash. This patch makes secure confirmation app observe the render frame host deletion, so the app can delete the authenticator that it owns before the associated render frame host is deleted. The android implementation (currently behind chrome://flags/#enable-web-platform-experimental-features flag) has been changed to match the desktop implementation (behind origin trial in M-86) to create the authenticator on the main frame of the web page, so cross-origin web pages can exercise the payment credential, too. After this patch, the authenticator is deleted before the render frame host, which avoids the crash. Bug: 1125614 Change-Id: I83502b1b6bf23b838211687497a6498d5c4777ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410348 Reviewed-by: Danyao Wang <danyao@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#808390}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.