[iOS] Handle double taps on the passkey welcome screen primary button

The primary action button of the passkey welcome screen (especially the
one leading to the enrollment process), can be tapped multiple times
before the action is executed and the next screen is presented. On the
second tap, `_primaryButtonAction` is `nil` resulting in a crash.

Another (an probably more common) scenario where the primary button
can be tapped more than once is when the enrollment keychain UI (shown
when tapping the primary button the first time) is dismissed with a
down swipe, leaving the passkey welcome screen at the top of the
navigation stack again. The button then becomes available an can be
tapped a second time, but crashes as `_primaryButtonAction` has become
`nil`.

This CL fixes the issue by only executing the block if the current
passkey welcome screen is still at the top of the navigation stack
(i.e., additional taps, if any, are ignored), and by allowing
`_primaryButtonAction` to be executed more than once by not setting it
to `nil` after it's first used.

Fixed: 379172052
Change-Id: I5df4f1769330dcc4b0568eab880f89a8780831e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6037963
Commit-Queue: Noémie St-Onge <noemies@google.com>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1385853}
1 file changed
tree: e0e2fd4846b23b129193d1de910512d8cdf9f541
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. .clang-format
  50. .clang-tidy
  51. .clangd
  52. .git-blame-ignore-revs
  53. .gitallowed
  54. .gitattributes
  55. .gitignore
  56. .gitmodules
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. CPPLINT.cfg
  68. CRYPTO_OWNERS
  69. DEPS
  70. DIR_METADATA
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.