commit | 6e1cd63cb9502fc7f2a139ea2e8cc2c3e6a5c9e8 | [log] [tgz] |
---|---|---|
author | Weilun Shi <sweilun@chromium.org> | Thu Jul 30 20:57:14 2020 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Jul 30 20:57:14 2020 |
tree | ba91b38ba5c868af091ff7fcfb7871238dff68eb | |
parent | 9ce66d435822c1521b9bc541d2076493a9531261 [diff] |
Populate ChromeOS hardware_class in metrics log Populate ChromeOS's hardware class in MetricsLog.RecordCoreSystemProfile by implementing ChromeOS version of the HardwareModelName so that the hardware_class field can be filled even for logs from previous run. This is to fix large amount of ChromeOS reports have no hardware_class problem. This cl doesn't implement anything new but moves part of the GetShortHardwareClass to ChromeOS's base::SysInfo::HardwareModelName(). This cl also does some cleanup in chromeos_metrics_provider and removes GetShortHardwareClass function in variations_field_trial_creator. The features::kUmaShortHWClass is always set to true now so some conditions are no longer needed. The GetShortHardwareClass function is replaced by base::SysInfo::HardwareModelName(). This cl will also affect our cloned install detection logic because ChromeOS machine id can also be detected. Though, we'll not reset client_ids because previously we never ran that logic. Bug: 1110166 Change-Id: Ia4261fe7da575eb12e0b9d6148924922bed2a168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321834 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#793335}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.