commit | 6e359266974048c401ce888aa67ec1337f9e2a29 | [log] [tgz] |
---|---|---|
author | Howard Yang <hcyang@google.com> | Tue Mar 25 23:46:36 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Mar 25 23:46:36 2025 |
tree | fc2f846f0217de000acfd3633b000ae87bf9d0f5 | |
parent | e9574ae6cc4faf1ab3be37d22e7e2c42fceb42b9 [diff] |
coral: Properly set coral chip title The correct title logic for coral chip is that a placeholder title would be set, then the actual title would be fetched from the group when initing the chip (because it could be nullopt). Loading animation / real title / placeholder title would show accordingly. But that logic was accidentally removed in https://crrev.com/c/6150035, to that the group title from request would be used directly, if provided. This introduces a bug that if the backend returns an empty title (which is intended, when we want to use placeholder title instead), the group will be filtered by birch model and not shown. This CL makes the group use placeholder title if the returned title is empty or null. Bug: b:405906928 Test: CQ Test: On device, test that title will be set correctly Change-Id: If4beffb9bab741be1f2f95b103c1945c7b7c795a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6381619 Reviewed-by: Xiaodan Zhu <zxdan@chromium.org> Commit-Queue: Howard Yang <hcyang@google.com> Cr-Commit-Position: refs/heads/main@{#1437835}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.