commit | 6e5ed24c41d0f1eb7b2bc0310499be10bc6edd1c | [log] [tgz] |
---|---|---|
author | Daseul Lee <dslee@chromium.org> | Tue Oct 31 21:01:21 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Oct 31 21:01:21 2023 |
tree | ea60a088c371a1187a6b2aaaaf073c824e9e5597 | |
parent | a057873202441c4ba82818993bbe6be55303dc86 [diff] |
[FSA] Update `queryPermission()` to include persistent permission state. Previously, even if a handle has persistent permission, `queryPermission()` could return `PermissionStatus::ASK`; only when `requestPermission()` is called, the persistent permission status would be retrieved for auto-granting. However, this could be a confusing behavior to API users, as the persistence of permission is implementation detail. `FileSystemAccessPermissionGrant.GetStatus()` is now updated to read from persisted grant objects and to return the combined state between active and persisted grants. This method is used not only for `queryPermission()` API, but also in various places internally such as returning child handles from a parent directory handle. Instead of introducing a new `GetPersistedStatus()`, the existing `GetStatus()` is updated to account for persistent permission. Additionally, a new private method `GetActivePermissionStatus()` is introduced to replace the former usage of `GetStatus()` within `ChromeFileSystemAccessPermissionContext`. Bug: 1011533 Change-Id: Ica5ca4f74395c6ccf66235f022b8ce345440b9d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4989830 Commit-Queue: Daseul Lee <dslee@chromium.org> Reviewed-by: Christine Smith <christinesm@chromium.org> Cr-Commit-Position: refs/heads/main@{#1217870}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.