Google Git
Sign in
chromium / chromium / src / 6e81798f08f11f751d5d996bedc95e741e876e02
commit6e81798f08f11f751d5d996bedc95e741e876e02[log] [tgz]
authorVictor Hugo Vianna Silva <victorvianna@google.com>Mon Aug 19 17:10:25 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Aug 19 17:10:25 2024
tree8591ff0cc093ec2f0977f0b1da2e85085847b903
parentdbb4b0b9d2db54e75eaa0cec4e5db70215b29c54 [diff]
[sync] Remove SyncService::StopAndClear() call only reachable in tests

Details below.
https://crbug.com/40797392#comment14
https://crbug.com/40797392#comment18

After this CL there is still one StopAndClear() call outside of
SyncServiceImpl but it happens in the chrome://sync-internals page [1].
I'll remove it in next CLs and make the method private.

[1] https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc;l=296;drc=25049133043552fee361754702d705e94da850e1

Bug: 40797392
Change-Id: I7ba6fb1c6c551deaffbeadeeaed1e62707b026d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5797212
Auto-Submit: Victor Vianna <victorvianna@google.com>
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1343576}
1 file changed
tree: 8591ff0cc093ec2f0977f0b1da2e85085847b903
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. CRYPTO_OWNERS
  78. DEPS
  79. DIR_METADATA
  80. LICENSE
  81. LICENSE.chromium_os
  82. OWNERS
  83. PRESUBMIT.py
  84. PRESUBMIT_test.py
  85. PRESUBMIT_test_mocks.py
  86. README.md
  87. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.