Textarea: Improve typing performance by reducing `value` creation Every typing in a textarea built the `value` string four times. 1. UpdateValue() call in SubtreeHasChanged() 2. IsInnerEditorValueEmpty() call in UpdatePlaceholderVisibility() 3. InnerEditorValue() call in SubtreeHasChanged() 4. CachedTextInputInfo::EnsureCached() We can use Value() for 2, 3 and 4. - Add TRACE_EVENT0() to HTMLTextAreaElement::SubtreeHasChanged(), which can be slow. - Use ComputeValue() in TextControlElement::InnerEditorValue(). ComputeValue() is faster than the existing code with StringBuilder. This CL reduces 5.9ms of typing lag in a textarea with 23k paragraphs. Bug: 414858401 Change-Id: Ia0abbaf46a1ca67b070b115bb1fac3f1fd97fb5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6549795 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1460519}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.