commit | 6eaaebbb5297e14c9bc051e7be822b7ddfaa8e0e | [log] [tgz] |
---|---|---|
author | Simon Zünd <szuend@chromium.org> | Fri May 17 06:09:12 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri May 17 06:09:12 2024 |
tree | 1742b9cb215e5e1a9277d935dd1e521c99eee3d4 | |
parent | 42579aef0070a4091225e8b077c92cd3c3fcbcab [diff] |
[devtools] Run 'SaveCallback' on the callers task runner https://crrev.com/c/5522321 added the 'is_base64' argument to the 'save' host binding. As part of the CL we also moved the time when we notify the caller from right before we write the file, to after the file was written (in order to fix test flakiness). The result was that the 'SaveCallback' was running on the file_task_runner, which is not correct. To fix this, we post the 'SaveCallback' task to the same task runner as was used to call DevToolsFileHelper::Save, but still after the file was actually written. This fixes the mojo CHECK that we emit the 'savedURL' host binding event on the wrong sequence. R=dsv@chromium.org Fixed: 340729479 Change-Id: I7c42e60150bcf3ad974d86263a592bf97f6433ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5537939 Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#1302425}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.