Google Git
Sign in
chromium / chromium / src / 6eb34a1a2b3d30c0e5a57670dffa2eb65609559d
commit6eb34a1a2b3d30c0e5a57670dffa2eb65609559d[log] [tgz]
authorthefrog <thefrog@chromium.org>Mon Aug 07 14:17:05 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Aug 07 14:17:05 2023
treec2325852e3f58d2e81e1e67a2cd3b95c463ff112
parent355fc9cb55a63dc4171747734331fc1cec0f708b [diff]
Fix logging of SafeBrowsing.RT.LocalMatch.Result.{IsMainframe} for iOS

Since `url_lookup_service_metric_suffix` is empty for iOS, the histogram
SafeBrowsing.RT.LocalMatch.Result.{IsMainframe} was being logged twice.
This CL avoids the second log when the suffix is empty.

Other changes in this CL:
 - URT test cases now validate the SafeBrowsing.RT.LocalMatch.Result.*
   metrics.
 - A new test case is added for an URT non-mainframe lookup.
 - A new test case is added for the specific bug (suffix = empty).
 - The test method CreateSafeBrowsingUrlChecker is refactored to take in
   a struct for optional args instead of individual optional parameters.
   This is so that test cases don't need to fill in the default values
   for irrelevant params when they want to set the value for another
   optional param.

Change-Id: I38cf42c4826599137edf4e96071882b072e29b40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4753852
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Commit-Queue: thefrog <thefrog@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1180275}
3 files changed
tree: c2325852e3f58d2e81e1e67a2cd3b95c463ff112
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.