Google Git
Sign in
chromium / chromium / src / 6ecc70e0b805689674d3ea8a3aa761bf6d46b533
commit6ecc70e0b805689674d3ea8a3aa761bf6d46b533[log] [tgz]
authorAnders Hartvoll Ruud <andruud@chromium.org>Fri Nov 19 16:32:00 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Nov 19 16:32:00 2021
tree0b19988338d254c1d738f34a21dcdc984b78fc9f
parentbd0af2c334da8a73c1be88ad7038bc92c26c61f8 [diff]
Avoid SetAnimationStyleChange(true) without a ComputedStyle

If the IsAnimationStyleChange is true, then CSSAnimations::
CalculateAnimationUpdate expects any CSS animations defined by the base
style to actually be present in |running_animations_|. However, this
will not be the case for elements with ShouldStoreComputedStyle()=false,
since any pending animation updates are canceled in Element::
RecalcOwnStyle if we ultimately don't want to store the newly
produced ComputedStyle.

Fixed: 1264236
Change-Id: I07dbdfe861de33f1d29e973b2fe6b5daf9b530c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3291749
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#943552}
2 files changed
tree: 0b19988338d254c1d738f34a21dcdc984b78fc9f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.