commit 6f013586f37900aef253908c7c66a17bd66d1d4e
author Peter Kasting <pkasting@chromium.org> Thu Nov 07 22:19:26 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Nov 07 22:19:26 2024
tree 1c35dded1b53afe4fc2acd5ec4329aa391693333
parent 9ddc1624637c8cfa8ef50a95abd779e0ba4d67f6

Span API tweaks, part 3.

* Adjust construction/conversion constraints to be slightly more
  correct (e.g. properly prevent make_span() from accepting things
  CTAD won't, such as non-const non-borrowed non-legacy rvalue
  ranges) and match std::span better. Added some nocompile tests.
* Prevent the legacy range constructor from accepting ranges that are
  actually "modern" ranges but fail that constructor's constraints
  (e.g. std::array or non-borrowed ranges of non-const T). (This is a
  stepping stone towards removing this constructor entirely, so we
  don't "backslide" on supposedly-disallowed usage, like construction
  of writable spans from non-const, non-borrowed ranges; added nocompile
  tests to verify.)
* Tweak deduction guides to match std::span better (though not yet
  perfectly). (This is a stepping stone toward adding the
  std::initializer_list constructor.)

Bug: 364987728
Change-Id: Ie8449a901b41ded48906a409c5fd5c0ffee9ca35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5985655
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1379978}